<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Hi Joris,</div><div><br></div><div>please see</div><div><br></div><div><a href="http://bugzilla.slf4j.org/show_bug.cgi?id=31">http://bugzilla.slf4j.org/show_bug.cgi?id=31</a></div><div><br></div><div>as well as</div><div><br></div><div><a href="http://bugzilla.slf4j.org/show_bug.cgi?id=70">http://bugzilla.slf4j.org/show_bug.cgi?id=70</a></div><div><br></div><div>for a discussion on the subject.</div><div><br></div><div>Changing the method signatures as you suggested would make the API incompatible to previous versions so this can't be done.</div><div><br></div><div>Beside that, I personally dislike the idea of writing the exception argument before the message because, semantically, I want to log a message and the exception is merely context and therefore at the end. </div><div><br></div><div>Regards, Joern.</div><br><div><div>On 28.09.2008, at 12:11, Joris Verschoor wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><span class="Apple-style-span" style="border-collapse: collapse; ">Hi guys,</span><div><span class="Apple-style-span" style="border-collapse: collapse; "><div><br></div><div>(I sent this message to the dev-list, but I guess that was the wrong place ;)</div> <div><br></div><div>I just migrated to <span class="nfakPe" style="background-image: initial; background-repeat: initial; background-attachment: initial; -webkit-background-clip: initial; -webkit-background-origin: initial; background-color: rgb(255, 255, 136); background-position: initial initial; ">slf4j</span>, and that worked pretty good..</div> <div><br></div><div>I have some suggestions (ofcouse:))</div><div><br></div><div>A Java5 version which supports varargs. I know that the method sigs support Object[], but varargs add some sugar.</div><div><br></div><div>Currently it is impossible to log an exception and parameterized args. </div> <div><br></div><div>I suggest the following signatures:</div><div><br></div><div>info(Marker, Throwable, String message)</div><div><div>info(Throwable, String message)<br></div><div><div>info(Marker, String message)<br></div> <div><br></div><div><div>info(Marker, Throwable, String message, Object[] args)</div><div><div>info(Throwable, String message, Object[] args)</div><div><div>info(Marker, String message, Object[] args)</div><div><br></div> <div><br></div><div>Object[] args can (and should also) be various helpers like it is now (1 and 2 Object args)</div><div><br></div><div>The idea is to have the message and it's args as the last arguments.</div><div> <br></div><div>The problem with the current signatures is that Throwable comes after the message and therefore making the args parameter ambiguous.</div><div><br></div><div></rant></div><div><br></div><font color="#888888"><div> Joris</div></font></div></div></div></div></div></span><br></div></div> _______________________________________________<br>user mailing list<br><a href="mailto:user@slf4j.org">user@slf4j.org</a><br>http://www.slf4j.org/mailman/listinfo/user</blockquote></div><br></body></html>