Ceki,<div><br></div><div>I think you are right: There seems to be no need for an abstract Logger (trait or abstract class) and a default implementation. Better have a single concrete Logger class wrapping a SLF4JLogger instance.</div>
<div><br></div><div>How shall we proceed? Wait some time and do the change then? Change it immediately?</div><div><br></div><div>Heiko</div><div><br><div class="gmail_quote">On 1 November 2010 22:28, Ceki Gülcü <span dir="ltr"><<a href="mailto:ceki@qos.ch">ceki@qos.ch</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><br>
Hello Heiko,<br>
<br>
Looking at logger.scala, I was wondering why the Logger trait was a trait and not a class. I understand that as a trait any class can mixin Logger and methods such as debug(), info() would be available in that class. However, there is already a trait caller Logging which allows the mixing class to write logger.debug("...").<br>
<br>
It seems to me that the Logging trait is sufficient in most cases. I would like to propose to make Logger a class instead of a Trait and to get rid of DefaultLogger. This would make the code a little simpler without loss of "desired" flexibility. I don't think we should allow classes to write just debug("...") or should we?<br>
<br>
WDYT?<br><font color="#888888">
<br>
--<br>
Ceki<br>
_______________________________________________<br>
slf4j-dev mailing list<br>
<a href="mailto:slf4j-dev@qos.ch" target="_blank">slf4j-dev@qos.ch</a><br>
<a href="http://qos.ch/mailman/listinfo/slf4j-dev" target="_blank">http://qos.ch/mailman/listinfo/slf4j-dev</a><br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Heiko Seeberger<br><br>Company: <a href="http://weiglewilczek.com" target="_blank">weiglewilczek.com</a><br>Blog: <a href="http://heikoseeberger.name" target="_blank">heikoseeberger.name</a><br>
Follow me: <a href="http://twitter.com/hseeberger" target="_blank">twitter.com/hseeberger</a><br>OSGi on Scala: <a href="http://scalamodules.org" target="_blank">scalamodules.org</a><br>Lift, the simply functional web framework: <a href="http://liftweb.net" target="_blank">liftweb.net</a><br>
Akka - Simpler Scalability, Fault-Tolerance, Concurrency & Remoting through Actors: <a href="http://akkasource.org" target="_blank">akkasource.org</a><br>
</div>