<div dir="ltr"><br><br><div class="gmail_quote">On Fri, Aug 1, 2008 at 9:29 PM, Ceki Gulcu <span dir="ltr"><listid@qos.ch></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br><div class="Ih2E3d"><br>
</div>The probability of passing a cyclical array is very low. Moreover, if and when<br>
it happens, the user will immediately know the cause of the failure. The<br>
StackOverflowError will point to MessageFormatter.deeplyAppendParameter method,<br>
so it will be easy to identify. If the bug were hard to identify, then it would<br>
have been an entirely different matter. At this stage, I am just too lazy to be<br>
bothered.<br>
<div class="Ih2E3d"></div></blockquote><div><br>Are you serious?<br><br>I once heard a lecture on logging and the prof said that the main objective of any logging framework must be to not break the application it is logging.<br>
<br>From this point of view - that I absolutely share - the quality of the slf4j framework would be lower after applying toString for arrays than before since now there is a real possibility to crash an application by simply issuing a log message.<br>
<br>It's also not our task to define that recursive arrays are a bug. With the previous implementation a log message containing such an array would have worked, with the new implementation it would crash the application.<br>
<br>Whether something like recursive arrays makes sense is purely application specific.<br><br>Beside that, the fix is really simple...<br></div></div></div>