Hi,<br><br>No objections at all.<br><br>Looking at my .proto file it's indeed pretty obvious that CallerData and StackTraceElement are quite similar :-)<br><a href="http://code.google.com/p/firewood/source/browse/trunk/compare-formats/src/main/java/com/googlecode/firewood/protobuf/logging.proto">http://code.google.com/p/firewood/source/browse/trunk/compare-formats/src/main/java/com/googlecode/firewood/protobuf/logging.proto</a><br>
<br>I've done some benchmarking with protobuf (using the Corpus), and it seems to be at least 4 times faster than Java serialization.<br>Will soon post the results and the code.<br><br>regards,<br>Maarten<br><br><div class="gmail_quote">
On Wed, Mar 18, 2009 at 12:12 PM, Ceki Gulcu <span dir="ltr"><ceki@qos.ch></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Hello,<br>
<br>
I would like to replace the CallerData class with<br>
StackTraceElement. The two classes contain the same fields.<br>
StackTraceElement is part of the JDK. I can think of no valid reason<br>
to duplicate a class found in the JDK.<br>
<br>
Comments/objections?<br><font color="#888888">
<br>
-- <br>
Ceki Gülcü<br>
Logback: The reliable, generic, fast and flexible logging framework for Java.<br>
<a href="http://logback.qos.ch" target="_blank">http://logback.qos.ch</a><br>
_______________________________________________<br>
logback-dev mailing list<br>
logback-dev@qos.ch<br>
<a href="http://qos.ch/mailman/listinfo/logback-dev" target="_blank">http://qos.ch/mailman/listinfo/logback-dev</a><br>
</font></blockquote></div><br>